Repository navigation
ts-sdk: fix ctx.from in a submodule view for explicitly named tables - #6661
Open
captain-mirage wants to merge 1 commit into
Open
captain-mirage wants to merge 1 commit into
captain-mirage wants to merge 1 commit into
Conversation
…uilder ctx.from in a submodule view joined the accessor namespace to the table's explicit canonical name. The host resolves the accessor path or the canonical path, not a mix, so the view failed with 'Error executing raw SQL returned by view'. Use the accessor name, as the submodule db view does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
A submodule view that returns
ctx.from.<table>fails withError executing raw SQL returned by viewwhen the table has an explicitname. The submodule query builder joined the accessor namespace to the table's canonical name ("camelLib"."named_item"). The host resolves the accessor path (camelLib.item) or the canonical path (camel_lib.named_item), but not a mix.The builder now uses the accessor name, as the submodule db view already does. #6358 edits the same line; I can rebase on whichever lands first.
API and ABI breaking changes
None
Rollback safety impact
n/a
Expected complexity level and risk
1
Testing
tests/ctx_as.test.ts, which fails on masterpnpm lint,tsc,pnpm test:unit(except the two wasm test-utils files, which need the Rust build)