Skip to content

ts-sdk: fix ctx.from in a submodule view for explicitly named tables - #6661

Open
captain-mirage wants to merge 1 commit into
clockworklabs:masterfrom
captain-mirage:fix/ts-submodule-view-from-accessor
Open

captain-mirage wants to merge 1 commit into
clockworklabs:masterfrom
captain-mirage:fix/ts-submodule-view-from-accessor

Conversation

@captain-mirage

Copy link
Copy Markdown
Contributor

Description of Changes

A submodule view that returns ctx.from.<table> fails with Error executing raw SQL returned by view when the table has an explicit name. The submodule query builder joined the accessor namespace to the table's canonical name ("camelLib"."named_item"). The host resolves the accessor path (camelLib.item) or the canonical path (camel_lib.named_item), but not a mix.

The builder now uses the accessor name, as the submodule db view already does. #6358 edits the same line; I can rebase on whichever lands first.

API and ABI breaking changes

None

Rollback safety impact

n/a

Expected complexity level and risk

1

Testing

  • New test in tests/ctx_as.test.ts, which fails on master
  • Against a 2.16.1 standalone: the view returned 400 before the change and rows after it
  • pnpm lint, tsc, pnpm test:unit (except the two wasm test-utils files, which need the Rust build)

…uilder

ctx.from in a submodule view joined the accessor namespace to the table's explicit canonical name. The host resolves the accessor path or the canonical path, not a mix, so the view failed with 'Error executing raw SQL returned by view'. Use the accessor name, as the submodule db view does.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant